Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that subsampled_streams is modified during iteration #327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

libeanim
Copy link
Contributor

This extracts the keys from subsampled_streams so it can be modified in the loop

  • I have read CONTRIBUTE.md

This extracts the keys from subsampled_streams so it can be modified in the loop
@libeanim libeanim changed the title Fix bug that subsampled_streams is modified during iteration WIP: Fix bug that subsampled_streams is modified during iteration Feb 26, 2024
@libeanim libeanim marked this pull request as draft February 26, 2024 15:43
@libeanim libeanim changed the title WIP: Fix bug that subsampled_streams is modified during iteration Fix bug that subsampled_streams is modified during iteration Feb 26, 2024
@libeanim
Copy link
Contributor Author

This also fixes a bug in the frame_subsampler.py were a wrong modality was selected when the downsampling method is set to keyframe

@libeanim libeanim marked this pull request as ready for review February 26, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant